This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds fs-extra methods. In the export section of the library, they are considered "after" fs-plus methods, so it will not have any conflict or breakage.
Future Improvements
The method that this PR adds fs-extra is minimal. Later, I will add support for named exports and tree-shaking.
Currently, there are a few methods that are used in both packages. Technically, we do not need to use mkdirp, rimraf, etc anymore since fs-extra supports all of these (with a more up to date implementation). Some other methods from the fs-plus are not using the native
fs
functions which means they do not support all types of inputs such as Buffer or URL. In future PRs, I will write a few type-dispatch sentences to decide between the native implementation and fs-plus implementation. This allows keeping the methods of fs-plus that offer anything interesting over the native fs functions.So, this PR paves the way for future PRs. 🚀
Benefits
fs-extra has many good methods which we can use. We will not need to install two separate fs library anymore! Including fs-extra in the Atom snapshot means that anyone using fs-extra will benefit from the speed up! 🎉
Verification
All the tests pass.
Release Notes