This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add support for reverting the value of a controlled input or select #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine you want a "controlled" color picker, so write the following:
And imagine you want to have an instance that refuses some colors:
This is not currently possible because when the
etch.update(this)
in thehandleChange
is called, it callsupdateProps
which updates theinput.value
only if the new value is!==
than the old one.But in this case the new value is always
===
the old one.Ref. lib/update-props.js:59
This PR solves this case for
input
andselect
type elements.