CI: Simplify preparation on Windows, Use Python 3.8 on all OSes #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
reviewed
Sep 8, 2020
aminya
requested changes
Sep 8, 2020
This comment has been minimized.
This comment has been minimized.
DeeDeeG
changed the title
aminya
reviewed
Sep 8, 2020
Co-authored-by: Amin Yahyaabadi <[email protected]>
DeeDeeG
force-pushed
the
CI-simplify-windows-preparation
branch
from
6028262 to
1191b31
Compare
aminya
approved these changes
Sep 9, 2020
aminya
added a commit
that referenced
this pull request
Sep 11, 2020
We already install the npm version we want in previous steps #140
aminya
added a commit
that referenced
this pull request
Sep 11, 2020
We already install the npm version we want in previous steps #140
aminya
added a commit
that referenced
this pull request
Sep 11, 2020
We already install the npm version we want in previous steps #140 Co-Authored-By: DeeDeeG <[email protected]>
aminya
added a commit
that referenced
this pull request
Sep 11, 2020
#140 Co-Authored-By: DeeDeeG <[email protected]>
aminya
added a commit
that referenced
this pull request
Sep 28, 2020
We already install the npm version we want in previous steps #140 Co-Authored-By: DeeDeeG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
npm install -g npm-windows-upgradeandnpm-windows-upgrade.npm install -g npmcommand.npm install -g npmcommand modifies the npm atC:/npm/prefix/npm.cmd. So we set theNPM_BIN_PATHenvironment variable to point to that path instead ofC:/hostedtoolcache/windows/node/[maj.min.patch]/x64/npm.cmd, which is the install thatnpm-windows-upgrademodifies.Quantitative Performance Benefits
About 45 seconds is saved before bootstrapping/building on Windows, and another 45 seconds is saved in each Windows test job.
npm-windows-upgradetakes about 20 secondsnpm-windows-upgradetakes about 24 or 25 seconds.See the time taken for those steps in this CI run for an example: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=625&view=logs&j=2985f0af-e798-5fdc-91b8-be9f0a3685c5&t=33143b02-a236-56d5-9221-c8b903d3c111
Possible Drawbacks
None.
Verification Process
CI Passes. For example: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=624&view=results
Windows correctly uses npm 6.14.8 as we have configured it to. See: https://dev.azure.com/DeeDeeG/b/_build/results?buildId=624&view=logs&j=2985f0af-e798-5fdc-91b8-be9f0a3685c5&t=9ceed7b2-fba1-5410-fd8f-91cfc59f4174 to confirm.
Applicable Issues
Closes #51.
Release Notes
N/A