-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft(#84): Fetch Trainee Notifications #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munezeromicha
force-pushed
the
ft-trainee-notifictions
branch
4 times, most recently
from
November 8, 2024 10:38
0e848b7
to
4a72cb7
Compare
munezeromicha
requested review from
aimeudoxie,
Mbabazi12,
fredshema,
ncutixavier,
pacifiquemboni,
MugemaneBertin2001 and
Christian-Ishimwe
and removed request for
aimeudoxie
November 8, 2024 10:40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Good work @munezeromicha but there is some issues i found
- Closing icon is not closing notificatin instead notifications are disappearing
- I dont think that we have select all option on the design even on web
- Icons to remove specific notification is not working
- notification are not being marked as read whether clicking on cetain notification or using Mark all as read button
Those issues might be happening on my end, if there are working on your end let me know
Closed
munezeromicha
force-pushed
the
ft-trainee-notifictions
branch
from
November 11, 2024 08:22
4a72cb7
to
96a8ee6
Compare
aimeudoxie
approved these changes
Nov 11, 2024
MugemaneBertin2001
approved these changes
Nov 11, 2024
pacifiquemboni
approved these changes
Nov 11, 2024
ncutixavier
changed the title
Fetch Trainee Notifications Using GraphQL Queries and Mutations
Fetch Trainee Notifications
Nov 11, 2024
munezeromicha
changed the title
Fetch Trainee Notifications
ft(#84): Fetch Trainee Notifications
Nov 11, 2024
munezeromicha
changed the title
ft(#84): Fetch Trainee Notifications
Ft(#84): Fetch Trainee Notifications
Nov 11, 2024
munezeromicha
force-pushed
the
ft-trainee-notifictions
branch
from
November 12, 2024 09:13
96a8ee6
to
d8c7195
Compare
Mbabazi12
approved these changes
Nov 13, 2024
munezeromicha
force-pushed
the
ft-trainee-notifictions
branch
from
November 13, 2024 10:46
d8c7195
to
96e6b84
Compare
Good work @munezeromicha, it is working well |
ncutixavier
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the functionality to fetch trainee notifications from the database using GraphQL queries and mutations. It enables real-time updates for notifications and allows trainees to mark notifications as read, improving user experience and data efficiency.
Description of Task to be completed
Fetch Trainee Notifications: Created a GET_TRAINEE_NOTIFICATIONS GraphQL query to retrieve notifications specific to trainees. This query includes fields such as id, message, createdAt, read status, and sender information.
Mark Notifications as Read: Implemented a MARK_NOTIFICATION_AS_READ mutation to allow trainees to mark notifications as read. This mutation updates the notification’s read status in the database.
Real-Time Notifications: Added a TRAINEE_NOTIFICATION_SUBSCRIPTION subscription for real-time notification updates. When a new notification is sent to a trainee, it is immediately pushed to their UI.
Frontend Integration: Integrated the GraphQL query, mutation, and subscription with the frontend to display notifications dynamically, handle real-time updates, and manage unread notification counts. Enhanced UI components to show notifications efficiently and updated styling where needed.
How should this be manually tested?
Fetch Notifications:
Mark as Read:
Error Handling:
Test with no internet connection and observe that appropriate error messages are displayed.
Screenshots: