-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compass 23919 Onboarding flow implement custom bridge method #149
Merged
svankayalapati-atlassian
merged 11 commits into
main
from
COMPASS-23919-gitlab-implement-custom-bridge-method
Jan 23, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a4f48c7
added bridge function calls and helper functions
svankayalapati-atlassian 166ec61
updated yarn.lock files
svankayalapati-atlassian ebdb2a8
fixing yarn files
svankayalapati-atlassian 497e810
fixing yarn files
svankayalapati-atlassian 1cb72df
removing forge-ui-types for now for testing
svankayalapati-atlassian b77a77d
fixing tests
svankayalapati-atlassian 7510695
adding extra line
svankayalapati-atlassian e1ed92b
removing extra line
svankayalapati-atlassian eb66db6
adding extra line
svankayalapati-atlassian bef3ef9
fixed onboarding helper func
svankayalapati-atlassian ee05fcc
remvoed unused imports
svankayalapati-atlassian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { view } from '@forge/bridge'; | ||
import { getCallBridge } from '@forge/bridge/out/bridge'; | ||
|
||
export async function isRenderingInOnboardingFlow(): Promise<boolean> { | ||
try { | ||
const context = await view.getContext(); | ||
return context.extension.renderingLocation === 'onboardingFlow'; | ||
} catch (error) { | ||
console.error('Error fetching onboarding flow context:', error); | ||
return false; | ||
} | ||
} | ||
|
||
export async function checkOnboardingRedirection(err?: string): Promise<void> { | ||
const isInOnboardingFlow = await isRenderingInOnboardingFlow(); | ||
if (isInOnboardingFlow) { | ||
const params = err ? { error: err } : undefined; | ||
await getCallBridge()('redirectOnboardingTube', params); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a TODO: comment here with a link to the task to import the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think due to the open source nature of this repo, it may be impossible to import that package which is not published to npm