Enable basic Maintainer token role UI inputs #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subbuvenk-atlas
force-pushed
the
isuse/COMPASS-23317-ui
branch
from
86a68d2 to
029ba1a
Compare
subbuvenk-atlas
commented
Dec 10, 2024
| @@ -25,6 +25,7 @@ module.exports = { | |||
| }, | |||
| ], | |||
| '@typescript-eslint/no-floating-promises': 'error', | |||
| '@typescript-eslint/no-empty-function': 'off', | |||
There was a problem hiding this comment.
This was blocking my builds occasionally and does not specify exactly what the issue might be. Following https://stackoverflow.com/questions/76457373/cannot-read-properties-of-undefined-reading-gettokens-occurred-while-linting.
There was a problem hiding this comment.
It looks like that rule misfires when applied to React code.
subbuvenk-atlas
force-pushed
the
isuse/COMPASS-23317-ui
branch
from
029ba1a to
8480cde
Compare
|
Has Shu looked at this UI yet? Im wondering if we should get a double check of this, and also see if we need to add some text explaining the differences between the inputs, and how to get them |
subbuvenk-atlas
force-pushed
the
isuse/COMPASS-23317-ui
branch
from
cf0a0a4 to
53d9971
Compare
subbuvenk-atlas
force-pushed
the
isuse/COMPASS-23317-ui
branch
from
53d9971 to
0dd1e2f
Compare
eserranovalle
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds UI to collect input to enable Maintainer role on tokens being used for integration. The additional inputs include - group name, webhook ID and webhook's secret token. The non-Owner route will involve some manual setup from users due to lack of privileges, which will be then setup using these inputs.
A new Auth UI step is added for Maintainer token usage for Webhooks setup. The state is persisted so that users can come back and resume Webhook setup from where they left off. Some guidance for this setup is also included in this UI step but will be polished further pending feedback from product.
All changes are behind a FF preserving existing flow + Owner token usage.
Checklist
Please ensure that each of these items has been addressed: