Fix bug where "import * as React from 'react'" is incompatible with @babel/plugin-transform-runtime #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…babel/plugin-transform-runtime
|
JakeLane
approved these changes
Mar 14, 2025
✅ Deploy Preview for compiled-css-in-js canceled.
|
1 similar comment
✅ Deploy Preview for compiled-css-in-js canceled.
|
| @@ -198,7 +198,7 @@ export default declare<State>((api) => { | |||
|
|
|||
| if (!pragma.jsxImportSource && shouldImportReact && !path.scope.getBinding('React')) { | |||
| // React is missing - add it in at the last moment! | |||
| path.unshiftContainer('body', template.ast(`import * as React from 'react'`)); | |||
There was a problem hiding this comment.
I would just put this behind a configuration, ship it disabled by default, try it internally, and swap the default…?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
@compiled/babel-pluginautomatically inserts a React import at the start of the file by default (as long asimportReactis not turned off), in the form ofimport * as React from 'react'. This PR changes this import toimport React from 'react'.Why are we making this change?
Fix bug where "import * as React from 'react'" is incompatible with @babel/plugin-transform-runtime
PR checklist
Don't delete me!
I have...
website/