Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove esbuild optimiser #20

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Remove esbuild optimiser #20

merged 2 commits into from
Aug 21, 2024

Conversation

MonicaOlejniczak
Copy link
Contributor

@MonicaOlejniczak MonicaOlejniczak commented Aug 20, 2024 •
edited
Loading

Motivation

The original @parcel/optimizer-esbuild is not used anywhere internally, and we do not need to continue supporting something that will never be used.

Changes

  • Remove @atlaspack/optimizer-esbuild package
  • Rename examples packages to remove -examples suffix for consistency
  • Fix examples so most of them work
  • Delete threejs example, since it is basically a benchmark that should be consumed in the benchmarks repo
  • Remove unnecessary dependencies and configuration from examples

Checklist

  • Existing or new tests cover this change

@MonicaOlejniczak MonicaOlejniczak force-pushed the monica/esbuild-optimizer branch 2 times, most recently from 55fafb8 to 800ddfe Compare August 20, 2024 08:40
@MonicaOlejniczak MonicaOlejniczak force-pushed the monica/esbuild-optimizer branch from 800ddfe to fa51a4f Compare August 20, 2024 08:42
@MonicaOlejniczak MonicaOlejniczak requested a review from a team August 21, 2024 03:17
@MonicaOlejniczak MonicaOlejniczak merged commit b48b214 into main Aug 21, 2024
17 checks passed
@MonicaOlejniczak MonicaOlejniczak deleted the monica/esbuild-optimizer branch August 21, 2024 03:30
Nikola-3 pushed a commit that referenced this pull request Oct 29, 2024
@MonicaOlejniczak
Remove esbuild optimiser (#20)
7d79db8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alshdavid alshdavid alshdavid approved these changes

@yamadapc yamadapc Awaiting requested review from yamadapc

@mattcompiles mattcompiles Awaiting requested review from mattcompiles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonicaOlejniczak @alshdavid