Skip to content

Commit

Permalink
Fix releases (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
MonicaOlejniczak authored Aug 20, 2024
1 parent 7bb54d4 commit a631d28
Show file tree
Hide file tree
Showing 23 changed files with 95 additions and 106 deletions.
27 changes: 13 additions & 14 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,15 @@ jobs:
if: ${{ runner.os == 'macOS' && inputs.profile == 'canary' }}
run: dsymutil packages/*/*/*.node
- name: Upload debug symbols
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ inputs.profile == 'canary' }}
with:
name: debug-symbols-${{ matrix.name }}
path: packages/*/*/*.node.dSYM/Contents/Resources/DWARF/*.node
- name: Strip debug symbols # https://github.com/rust-lang/rust/issues/46034
run: strip -x packages/*/*/*.node # Must use -x on macOS. This produces larger results on linux.
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bindings-${{ matrix.name }}
path: packages/*/*/*.node
Expand All @@ -85,7 +85,7 @@ jobs:
container:
image: node:22.4-bullseye
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
Expand All @@ -102,19 +102,19 @@ jobs:
find packages -name "*.node" -type f -exec objcopy --strip-debug --strip-unneeded {} \;
find packages -name "*.node" -type f -exec objcopy --add-gnu-debuglink={}.debug {} \;
- name: Upload debug symbols
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ inputs.profile == 'canary' }}
with:
name: debug-symbols-linux-gnu-x64
path: packages/*/*/*.node.debug
- name: Strip debug symbols # https://github.com/rust-lang/rust/issues/46034
run: strip packages/*/*/*.node
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bindings-linux-gnu-x64
path: packages/*/*/*.node
- name: debug
- name: Debug
run: ls -l packages/*/*/*.node
- name: Smoke test
run: node -e 'require("@atlaspack/rust")'
Expand Down Expand Up @@ -164,24 +164,24 @@ jobs:
find packages -name "*.node" -type f -exec ${{ matrix.objcopy }} --strip-debug --strip-unneeded {} \;
find packages -name "*.node" -type f -exec ${{ matrix.objcopy }} --add-gnu-debuglink={}.debug {} \;
- name: Upload debug symbols
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ inputs.profile == 'canary' }}
with:
name: debug-symbols-${{ matrix.target }}
path: packages/*/*/*.node.debug
- name: Strip debug symbols # https://github.com/rust-lang/rust/issues/46034
run: ${{ matrix.strip }} packages/*/*/*.node
- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bindings-${{ matrix.target }}
path: packages/*/*/*.node
- name: debug
- name: Debug
run: ls -l packages/*/*/*.node
- name: Configure binfmt-support
run: docker run --rm --privileged multiarch/qemu-user-static:register --reset
- name: Smoke test
uses: addnab/docker-run-action@v1
uses: addnab/docker-run-action@v3
with:
image: ghcr.io/devongovett/multiarch-node:node14-${{ matrix.arch }}-focal
options: -v ${{github.workspace}}:/work
Expand All @@ -202,7 +202,7 @@ jobs:
- name: Build native packages
run: yarn build-native-${{ inputs.profile }}
- name: Download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts
- name: Move bindings
Expand All @@ -215,14 +215,13 @@ jobs:
find artifacts -name "*.node" -path "**/DWARF/**" -exec cp {} debug-symbols/ \;
ls -l debug-symbols
- name: Upload combined debug symbols artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: ${{ inputs.profile == 'canary' }}
with:
name: debug-symbols
path: debug-symbols/**
- name: Debug
run: |
ls -l packages/*/*/*.node
run: ls -l packages/*/*/*.node
- run: echo //registry.npmjs.org/:_authToken=${NPM_TOKEN} > .npmrc
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ tmp
# Ignoring main README for now because generated Table of Contents adds a line that prettier removes
# in precommit hook, causing `yarn lint:readme` to fail
/README.md
/packages/core/atlaspack/README.md
/packages/core/cli/README.md
2 changes: 1 addition & 1 deletion README.md
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Special thanks to [Devon](https://github.com/devongovett) for his invaluable con
## Installation

```sh
npm install --save-dev atlaspack
npm install --save-dev @atlaspack/cli
```

## Usage
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "atlaspack",
"name": "@atlaspack/cli",
"version": "2.12.0",
"description": "Blazing fast, zero configuration web application bundler",
"license": "MIT",
Expand All @@ -10,7 +10,9 @@
"type": "git",
"url": "https://github.com/atlassian-labs/atlaspack.git"
},
"bin": "bin/atlaspack.js",
"bin": {
"atlaspack": "bin/atlaspack.js"
},
"main": "lib/bin.js",
"source": "src/bin.js",
"scripts": {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/core/integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"test-ci": "yarn test --config .mocharc.ci.json --reporter mocha-multi-reporters --reporter-options configFile=./test/mochareporters.json"
},
"devDependencies": {
"@atlaspack/cli": "2.12.0",
"@babel/core": "^7.22.11",
"@babel/plugin-syntax-class-properties": "^7.12.13",
"@babel/plugin-syntax-export-default-from": "^7.22.5",
Expand Down Expand Up @@ -39,7 +40,6 @@
"lodash": "^4.17.15",
"ncp": "^2.0.0",
"nib": "^1.1.2",
"atlaspack": "2.12.0",
"postcss": "^8.4.5",
"postcss-custom-properties": "^12.1.2",
"postcss-import": "^14.0.2",
Expand Down
Loading

0 comments on commit a631d28

Please sign in to comment.