external mismatch rule checks peer deps #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External mismatch rule will check peer deps for version enforcement.
allowedDependencyVersions
:a) if multiple versions are configured in
allowedDependencyVersions
, like ["^2.0.0", "^3.0.0"], then it'll fix to "foo": "^2.0.0 || ^3.0.0"b) if no versions are configured in
allowedDependencyVersions
, then it'll fix to the most common version; and if there's no most common version, it'll fix to the first version. e.g "foo": "^1.0.0 || ^2.0.0" => "foo": "^1.0.0"Testing plan:
link the package to atlassian-frontend and run
yarn manypkg fix
in different cases.react
to "^17.0.0 || ^18.0.0". It should get clamped to "^16.8.0 || ^18.0.0"react
to "^18.0.0". It should pass the check