Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve source heading buttons and interactions. #3202

Merged
merged 5 commits into from
Nov 26, 2023
Merged

Improve source heading buttons and interactions. #3202

merged 5 commits into from
Nov 26, 2023

Commits on Nov 26, 2023

  1. gitmodules: Update prompter.

    @aadcg
    aadcg committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    399d481 View commit details
    Browse the repository at this point in the history

  2. prompt-buffer: Improve source heading buttons. 

    Change button glyphs for `next-source`, `previous-source` and
`toggle-attributes-display`.  Show keybinding on hover.  Not all added glyphs
are being used, but they may be useful in the future.

Move `toggle-attributes-source` button to the right.

Mute next/previous source arrow when next/previous source is unavailable.

Review CSS.
    @hgluka @aadcg
    hgluka authored and aadcg committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f1603ac View commit details
    Browse the repository at this point in the history

  3. prompt-buffer: Remove inactive buttons logic. 

    The previous commit introduces a UI glitch where the left arrow down button is
drawn as inactive by a brief moment.  The root cause isn't related to the
implementation of the feature itself, but due to the poor architecture design of
update-prompt-input.

Steps to reproduce:

- Invoke execute-command
- Run `(update-prompt-input (current-prompt-buffer) "fo")`

The issue can be understood by inspecting the calls to
`(prompt-render-suggestions prompt-buffer)` in `update-prompt-input`.
    @aadcg
    aadcg committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    fa3dc25 View commit details
    Browse the repository at this point in the history

  4. prompt-buffer: Review style.

    @aadcg
    aadcg committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c43cb59 View commit details
    Browse the repository at this point in the history

  5. changelog: Mention source heading UI improvement.

    @aadcg
    aadcg committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6450b4a View commit details
    Browse the repository at this point in the history