Skip to content

Commit

Permalink
prompt-buffer.lisp: Correct prompt buffer arrows.
Browse files Browse the repository at this point in the history
  • Loading branch information
jmercouris committed Jan 11, 2024
1 parent e5748b4 commit 37537c7
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions source/prompt-buffer.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,26 @@ See `nyxt::attribute-widths'.")
:margin-left "10px"
:margin-top "15px")
`(".source-name"
:padding-left "4px"
:background-color ,theme:secondary
:color ,theme:on-secondary
:display "flex"
:justify-content "space-between"
:align-items "stretch"
:line-height "24px"
:border-radius "3px 0 0 0")
:border-radius "2px 0 0 0")
'(".source-name > div"
:line-height "22px")
`(".source-name > div > button"
:padding "5px 4px 5px 4px"
:min-height "100%")
`("#next-source > svg, #previous-source > svg"
:margin-bottom "2px"
:height "5px")
'("#previous-source"
:margin-left "-6px"
:padding 0)
'("#next-source"
:padding 0)
`("#suggestions"
:background-color ,theme:background
:color ,theme:on-background
Expand Down Expand Up @@ -530,7 +540,7 @@ This does not redraw the whole prompt buffer, use `prompt-render' for that."
(:div
(:nbutton
:id "next-source"
:text (:raw (gethash "down-arrow.svg" *static-data*))
:text (:raw (gethash "down.svg" *static-data*))
:title (format nil "Next source (~a)"
(binding-keys (sym:resolve-symbol :next-source
:command)
Expand All @@ -539,7 +549,7 @@ This does not redraw the whole prompt buffer, use `prompt-render' for that."
'(funcall (sym:resolve-symbol :next-source :command)))
(:nbutton
:id "previous-source"
:text (:raw (gethash "up-arrow.svg" *static-data*))
:text (:raw (gethash "up.svg" *static-data*))
:title (format nil "Previous source (~a)"
(binding-keys (sym:resolve-symbol :previous-source
:command)
Expand Down

2 comments on commit 37537c7

@aadcg
Copy link
Member

@aadcg aadcg commented on 37537c7 Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost sure that in PR #3202 @lansingthomas decided to use up-arrow instead of up but I don't recall the reason. I also prefer up, i.e. as @jmercouris did here.

@jmercouris
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I do know that Thomas does approve of the new arrows though. Probably there was some challenge with rendering them or something.

Please sign in to comment.