Small update to trace-based failure models #271
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the trace, the model should start. Added repeat to TraceBasedFailureModel.kt. This decides if the trace should be repeated when finished
sacheendra
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added startPoint to TraceBasedFailureModel.kt, this decides where in the trace, the model should start.
Added repeat to TraceBasedFailureModel.kt. This decides if the trace should be repeated when finished.
Added a no failure model to the FailiureModelSpecs. The user can now add a FailureModel with type "no". This will do nothing, but is needed if you want to create an experiment that should run simulations with and without failures.
Implementation Notes ⚒️
N / A
External Dependencies 🍀
N / A
Breaking API Changes⚠️
N / A
Simply specify none (N/A) if not applicable.