updated ScenarioFactory and ScenarioSpec #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacheendra
approved these changes
Jul 31, 2024
Radu-Nicolae
added a commit
to Radu-Nicolae/opendc-m3sa
that referenced
this pull request
Aug 8, 2024
This reverts commit b287789.
Radu-Nicolae
added a commit
to Radu-Nicolae/opendc-m3sa
that referenced
this pull request
Aug 8, 2024
Revert "updated ScenarioFactory and ScenarioSpec (atlarge-research#239)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the way the scenarios are generated from a scenario JSON file.
The function getCartesian() is added to ScenariosSpec which creates a sequence of scenarios using the cartesian product.
This removes the nested for loop in ScenarioRunner.
Implementation Notes ⚒️
External Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.