Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ-375 : Char limit increase for dataContractSpec and dataContractJson #3528

Merged
merged 3 commits into from
Sep 18, 2024
Merged

DQ-375 : Char limit increase for dataContractSpec and dataContractJson #3528

merged 3 commits into from
Sep 18, 2024

Conversation

bichitra95
Copy link
Collaborator

@bichitra95 bichitra95 commented Sep 17, 2024 •
edited
Loading

Change description

Increase the char limit from 100k to 2 million for dataContractSpec and dataContractJson.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bichitra95 bichitra95 changed the title DQ 375: Char limit increase for dataContractSpec and dataContractJson DQ-375 : Char limit increase for dataContractSpec and dataContractJson Sep 17, 2024
sumandas0
sumandas0 approved these changes Sep 17, 2024
View reviewed changes
Copy link

@sumandas0 sumandas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already had discussions related to this, its all fine! Feel free to merge

nikhilbonte21
nikhilbonte21 approved these changes Sep 17, 2024
View reviewed changes
Copy link

@nikhilbonte21 nikhilbonte21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Check with @mehtaanshul before merging regarding do not need any change for these attributes mappings on ElasticSearch index

@bichitra95 bichitra95 merged commit e78d2e6 into master Sep 18, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

@sumandas0 sumandas0 sumandas0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bichitra95 @sumandas0 @nikhilbonte21