Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-192 Bulk link api for domain<>asset link #3448

Merged
merged 29 commits into from
Sep 11, 2024
Merged

MESH-192 Bulk link api for domain<>asset link #3448

merged 29 commits into from
Sep 11, 2024

Conversation

PRATHAM2002-DS
Copy link

@PRATHAM2002-DS PRATHAM2002-DS commented Aug 29, 2024 •
edited
Loading

Change description

Created a custom API with minimum validations for bulk link domains usecase.

Testcase Doc

https://docs.google.com/spreadsheets/d/1I3JJ4gp_JUMcc4KXSX57RTZM-23ANu06SvDHQ-vDGpE/edit?gid=0#gid=0

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@PRATHAM2002-DS PRATHAM2002-DS changed the title Mesh 148 link api MESH-192: Bulk link api for domain<>asset link Aug 29, 2024
@PRATHAM2002-DS PRATHAM2002-DS changed the title MESH-192: Bulk link api for domain<>asset link MESH-192 : Bulk link api for domain<>asset link Aug 29, 2024
nikhilbonte21
nikhilbonte21 requested changes Aug 29, 2024
View reviewed changes
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Outdated Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Outdated Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Outdated Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Outdated Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Outdated Show resolved Hide resolved
nikhilbonte21
nikhilbonte21 requested changes Sep 9, 2024
View reviewed changes
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Show resolved Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Outdated Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Show resolved Hide resolved
webapp/src/main/java/org/apache/atlas/web/rest/MeshEntityAssetLinkREST.java Show resolved Hide resolved
@PRATHAM2002-DS PRATHAM2002-DS changed the title MESH-192 : Bulk link api for domain<>asset link MESH-192 Bulk link api for domain<>asset link Sep 10, 2024
@nikhilbonte21 nikhilbonte21 merged commit 51a6c3d into master Sep 11, 2024
9 checks passed
@sumandas0 sumandas0 deleted the mesh-148-link-api branch September 12, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PRATHAM2002-DS @nikhilbonte21