Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESH-184 Validations for domainGUIDs de-norm attribute #3442

Merged
merged 21 commits into from
Sep 11, 2024
Merged

MESH-184 Validations for domainGUIDs de-norm attribute #3442

merged 21 commits into from
Sep 11, 2024

Conversation

PRATHAM2002-DS
Copy link

@PRATHAM2002-DS PRATHAM2002-DS commented Aug 27, 2024 •
edited
Loading

Change description

A new default pre-processor is added AssetPreProcessor which is executed after execution of specific asset pre-processors if any, and handles only updating dataDomainGUIDs attribute for linking domains

Testcase Doc

https://www.notion.so/atlanhq/Test-cases-for-MESH-184-Validations-for-domain-asset-linking-180f9fae4a1d46bdafac27113bac869e

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

nikhilbonte21
nikhilbonte21 requested changes Sep 10, 2024
View reviewed changes
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...org/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataDomainPreProcessor.java Outdated Show resolved Hide resolved
nikhilbonte21
nikhilbonte21 previously approved these changes Sep 10, 2024
View reviewed changes
@PRATHAM2002-DS PRATHAM2002-DS requested review from sumandas0 and removed request for mehtaanshul September 10, 2024 18:40
@nikhilbonte21 nikhilbonte21 merged commit 05fdc37 into master Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

@sumandas0 sumandas0 Awaiting requested review from sumandas0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PRATHAM2002-DS @nikhilbonte21