Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3265

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

DG-1442 Modification of the PreProcessor for Custom Sort - Bulk Update Edge Cases #3265

wants to merge 19 commits into from

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Jun 19, 2024

Change description

Glossary Entities can be created/modified from non-FE methods as well, so we needed to add logic to add appropriate lexicographicalSortOrder Attribute to the entity in case it is not sent from user.
Also added validation regarding valid and appropriate lexoranks in context to the entity being sent.

Type of change

  • New feature (adds functionality)

Related Docs

Ticket
TestCases

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

hr2904 added 15 commits June 19, 2024 12:20
@hr2904
Init commmit, added lexorank generation util lib and logic for append…
7354911 
…ing the lexo attribute to category.
@hr2904
Added method to append lexicographicSortOrder attribute to any Glossa…
22326c8 
…ry based Entity that does not have it while creation.
@hr2904
Added LexoRank Validation method, with tentative rebalancing trigger …
7af1a45 
…logic
@hr2904
Corrected a method rename
9ca21c5
@hr2904
Added a check in validateLexoRank which checks if another entity with…
a51e3ba 
… duplicate lexorank doesnt exist in scenario where lexorank is being sent from user.
@hr2904
Added a check , such that if bulk request is from migration, it will …
4303ae7 
…override the check for for duplicate lexorank.
@hr2904
Modified ES query.
d0ee0bc
@hr2904
Modified an edge statement such that, when a new lexorank for cat is …
de5cead 
…generated, it is not a duplicate of a term in same linear data set
@hr2904
Reverted the check, instead added padded new offset for terms.
14ab6e6
@hr2904
fixed the caching logic, by adding the bifurcation for terms and cate…
f35949f 
…gories
@hr2904
Fixed PR comments
42588b3
@hr2904
Added caching for same ranks in same request, for prevention of dupli…
27da407 
…cacy.
@hr2904
Fixed a minor bug where an empty lexo attribute in update call was re…
c541587 
…moving the attribute from the vertex.
@hr2904
Fixed PR comments
80335ab
@hr2904
Reverted the AbstractGlossaryPreProcessor file , previously edited.
ab3082f
nikhilbonte21
nikhilbonte21 requested changes Jun 20, 2024
View reviewed changes
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/CategoryPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java Outdated Show resolved Hide resolved
...a/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/GlossaryPreProcessor.java Outdated Show resolved Hide resolved
.../java/org/apache/atlas/repository/store/graph/v2/preprocessor/glossary/TermPreProcessor.java Outdated Show resolved Hide resolved
nikhilbonte21
nikhilbonte21 previously approved these changes Jun 26, 2024
View reviewed changes
mehtaanshul
mehtaanshul previously approved these changes Jun 28, 2024
View reviewed changes
@hr2904 hr2904 dismissed stale reviews from mehtaanshul and nikhilbonte21 via c4e1cbb June 28, 2024 09:17
mehtaanshul
mehtaanshul previously approved these changes Jun 28, 2024
View reviewed changes
nikhilbonte21
nikhilbonte21 previously approved these changes Jun 28, 2024
View reviewed changes
@nikhilbonte21
Copy link

Changes look good to me, I will do a quick testing tomorrow on datamesh.atlan.com before approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehtaanshul mehtaanshul mehtaanshul left review comments

@nikhilbonte21 nikhilbonte21 nikhilbonte21 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hr2904 @nikhilbonte21 @mehtaanshul