Make colors generator public to allow for customized colors for chart #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Dec 20, 2022
| @@ -46,7 +46,7 @@ class Chart extends View | |||
| protected $datasets; | |||
|
|
|||
| /** @var ColorGenerator */ | |||
| protected $colorGenerator; | |||
| public $colorGenerator; | |||
mvorisek
reviewed
Dec 20, 2022
| @@ -16,7 +16,7 @@ class ColorGenerator | |||
| * | |||
| * @var array<int, array<int, string>> | |||
| */ | |||
| protected $colors = [ | |||
| public $colors = [ | |||
There was a problem hiding this comment.
there is a setter method for it :)
DarkSide666
approved these changes
Dec 20, 2022
|
@DarkSide666 did you read the comments? |
|
Oh, I got Covid and somehow missed them. Would you like to revert this? Looks like it's useless if we use DI and setter method instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyond having an automatied ColorGenerator, it needs to be possible to set the colour scheme per chart easily. Thus, both ColorGenerator and its $color definition should be public.