test(cluster): should respond when disable default response is true #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinBol
force-pushed
the
fix/default-response
branch
2 times, most recently
from
49ce47e to
53570cd
Compare
The tests ensure that: 1. A cluster specific response is sent even when disable default response is set. 2. A default response is not sent when disable default response is set. 3. A default response is not sent in response to receiving a default response. 4. A default response is not sent in response to a group addressed frame. 5. A default response (error status) is sent when the frame could not be handled by the resp. cluster.
RobinBol
force-pushed
the
fix/default-response
branch
from
53570cd to
9ee11bc
Compare
…onse even if disable default response is set to true Fixes: https://support.developer.homey.app/a/tickets/218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle frame should respond with cluster specific response even if disable default response is set to true.
Endpoint.handleFrameto make the tests pass: 0160278