Skip to content

Commit

Permalink
start-vswitch.sh: update how devices are described.
Browse files Browse the repository at this point in the history
--devices now include an optional port number, in addition
to the PCI location ID.  For example, "0000:86:00.1/0"

The new handling of device nameing becomes quite extensive,
and we still need to fix some of these switch-types to
work with the new naming format.
  • Loading branch information
atheurer committed Aug 16, 2018
1 parent e4094a7 commit c096ce1
Showing 1 changed file with 230 additions and 217 deletions.
Loading

4 comments on commit c096ce1

@k-rister
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atheurer - Can you provide some background on this?

@atheurer
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-rister We had to do this because there are some NICs which have more than 1 "netdev" per physical port on the card. Our code assumed there was always a 1:1 relationship between a physical-function and a netdev. So, we have to change everything that works with a physical-function and its netdev (like "eth0").

I see I may have inadvertently committed some other changes which I will back out shortly

@k-rister
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was just wondering if this was something new or something you just have had lingering for awhile.

@atheurer
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been meaning to commit it for a few weeks but just now got around to it. We may have others who need to use this functionality soon, so we wanted it in the repo. BTW, I am pretty sure some changes will be necessary for VPP.

Please sign in to comment.