Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle hook_user_login_check_t->mu being null #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

handle hook_user_login_check_t->mu being null #53

wants to merge 2 commits into from

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Nov 28, 2021

@jesopo jesopo mentioned this pull request Nov 28, 2021
Open
dwfreed
dwfreed suggested changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@dwfreed dwfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the mu usage on new line 192 (GH doesn't allow commenting on expanded context lines)

@jesopo
Copy link
Member Author

jesopo commented Nov 28, 2021

you're a lifesaver

dwfreed
dwfreed approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@dwfreed dwfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from an "implementation is sound" perspective; I don't know how I feel about the reason for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwfreed dwfreed dwfreed approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesopo @dwfreed