Fix ohmienvelope with wigglers #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swhite2401 : did you check your test file ? I don't have a test file immediately available… |
|
All this shows the drawback of having hard-coded passmethod names… Too bad that there is no other way! |
|
I haven't test this specific branch but I fixed the passmethod name in my test branch and it works so on my side it is fine |
We could make an enum somewhere that maps the passmethod names to centralizes in only one place the hard-coded names. This would mitigate this sort of typos |
This was referenced Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869. ohmienvelope fails with wigglers because of a typo in passmethod names
This also includes similar bug fixes in the same files in #868 and #866