Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Plugin.SetOutputTarget method #268

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix Plugin.SetOutputTarget method #268

merged 2 commits into from
Oct 17, 2024

Commits on Oct 17, 2024

  1. Add test cases for Plugin.SetOutputTarget 

    New tests:

- `TestPluginSetOutputTargetIsValidWithValidInput`
  - basic assertion to show that the method works as intended
    with valid/expected input
- TestPluginSetOutputTargetIsValidWithInvalidInput
  - asserts that when given an invalid output target that the
    default/fallback output target is used instead

The second test is currently failing, highlighting the logic
bug currently affecting the `Plugin.SetOutputTarget` method.

refs GH-267
    @atc0005
    atc0005 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    98e6277 View commit details
    Browse the repository at this point in the history

  2. Fix Plugin.SetOutputTarget fallback behavior 

    Correctly fallback to default output target when an invalid
output target is provided.

refs GH-267
    @atc0005
    atc0005 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2d05ce5 View commit details
    Browse the repository at this point in the history