Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Emojis + AN IMPORTANT NOTE #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add New Emojis + AN IMPORTANT NOTE #1

wants to merge 5 commits into from

Conversation

MOHAMED-EHAB-DEV
Copy link

@MOHAMED-EHAB-DEV MOHAMED-EHAB-DEV commented Jun 2, 2022 •
edited
Loading

Hi Guys

I add a new emoji and add AN IMPORTANT NOTE to add a new emoji

fixes #8

@MOHAMED-EHAB-DEV
Copy link
Author

@atapas

@MOHAMED-EHAB-DEV
Copy link
Author

@atapas, Please Review

atapas
atapas requested changes Jun 13, 2022
View reviewed changes
Copy link
Owner

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Programming-School-Pro-Coding Provided review comments.

Also please create an issue for this PR. Thanks.

README.md Outdated
@@ -226,12 +226,14 @@ Did you know I have [Website](https://tapasadhikary.com)?
**Syntax:**

```
:mango: :lemon: :man: :car:
:mango: :lemon: :man: :car: :fearful:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is not needed. As we already have 4 examples.

README.md Outdated
:mango: :lemon: :man: :car:
:mango: :lemon: :man: :car: :fearful:

> NOTE: If you want to more emojis you can type : and type a word to search for emojis like this ``` :mango: ```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one more sentence saying, this syntax may not be supported on all the markdown variant platforms.

@atapas
Copy link
Owner

atapas commented Jun 16, 2022

@Programming-School-Pro-Coding Will you take care of the comments?

@atapas
Copy link
Owner

atapas commented Jun 21, 2022

@Programming-School-Pro-Coding Will you take care of the comments?

@Programming-School-Pro-Coding Any update?

@atapas
Copy link
Owner

atapas commented Sep 20, 2022

@Programming-School-Pro-Coding Will you take care of the comments?

@Programming-School-Pro-Coding Any update?

@Programming-School-Pro-Coding Hi Are you working on this one any more?

@MOHAMED-EHAB-DEV
Copy link
Author

@Programming-School-Pro-Coding Will you take care of the comments?

@Programming-School-Pro-Coding Any update?

@Programming-School-Pro-Coding Hi Are you working on this one any more?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas Awaiting requested review from atapas

Requested changes must be addressed to merge this pull request.

Assignees

@MOHAMED-EHAB-DEV MOHAMED-EHAB-DEV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more emojis and add some notes(Comments)
2 participants
@MOHAMED-EHAB-DEV @atapas