Skip to content

Commit

Permalink
Skip Checkstyle for Local Staging (#271)
Browse files Browse the repository at this point in the history
Motivation:
Local staging phase causes release action to fail due to Checkstyle
errors.

Modifications:
Checkstyle is now skipped.

Result:
Local staging operates smoothly.
  • Loading branch information
jchrys committed Apr 6, 2024
1 parent 8641fc4 commit 8c699e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/scripts/release_rollback.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#
set -e

TAG=$(grep scm.tag= release.properties | cut -d'=' -f2)
TAG=$(grep scm.tag= r2dbc-mysql/release.properties | cut -d'=' -f2)
git remote set-url origin [email protected]:asyncer-io/r2dbc-mysql.git
git fetch
git checkout "$1"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
working-directory: ./prepare-workspace/
run: |
cat <(echo -e "${{ secrets.GPG_PRIVATE_KEY }}") | gpg --batch --import
./mvnw -B -ntp -am -pl r2dbc-mysql clean javadoc:jar package gpg:sign org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DnexusUrl=https://s01.oss.sonatype.org -DserverId=ossrh-staging -DaltStagingDirectory=/home/runner/local-staging -DskipRemoteStaging=true -DskipTests=true -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}" -Dgpg.keyname="${{ secrets.GPG_KEY_NAME }}"
./mvnw -B -ntp -am -pl r2dbc-mysql clean javadoc:jar package gpg:sign org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DnexusUrl=https://s01.oss.sonatype.org -DserverId=ossrh-staging -DaltStagingDirectory=/home/runner/local-staging -DskipRemoteStaging=true -DskipTests=true -Dcheckstyle.skip -Dgpg.passphrase="${{ secrets.GPG_PASSPHRASE }}" -Dgpg.keyname="${{ secrets.GPG_KEY_NAME }}"
- name: Prepare Internal Dependencies
run: ./mvnw -B -ntp -pl build-tools clean install -DskipTests -Dcheckstyle.skip
Expand All @@ -141,5 +141,5 @@ jobs:
- name: Rollback Release
working-directory: ./prepare-workspace/
if: ${{ failure() }}
run: ./.github/scripts/release_rollback.sh
run: ./.github/scripts/release_rollback.sh trunk

0 comments on commit 8c699e3

Please sign in to comment.