-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3702
chore: update meetings.json and newsrooom_videos.json #3702
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3702 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
dashboard.json (3)
168-177
: New GoodFirstIssue: Octokit Package Update
A new issue entry for updating support to@octokit/request v9
and@octokit/graphql v8
has been added. The fields (id
,resourcePath
,repo
,author
,area
, andlabels
) seem to be correctly populated. Consider adding a bit more context or pointers in the issue description for new contributors if needed.
203-217
: New GoodFirstIssue: Smooth Transition for Search Modal
The addition of the issue "[FEATURE] Add smooth transition to the search modal opening" is noted. One point to verify is that thearea
is set as"Unknown"
—confirm if this is intended or if it should be updated for better categorization.
218-232
: New GoodFirstIssue: Scroll-to-Top Button Design Improvement
The issue "[FEATURE] Improving scroll to top button elegent and clean design" has been introduced. The implementation is correct; however, please confirm whether"elegent"
is an intentional choice or a typographical error (likely intended to be"elegant"
).
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
dashboard.json
(3 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (7)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Lighthouse CI
🔇 Additional comments (4)
dashboard.json (4)
12-12
: Score Update for Existing Discussion
The score for the discussion titled "refactor: migrate build script to typescript" has been updated to62.31688575858915
. This update appears consistent with the expected metric improvements.
116-143
: New Discussion Entry: "Budget 2025"
A new discussion item for "Budget 2025" has been added with all the required fields including proper labels (enhancement
,vote
,gitvote
,vote open
) and a score of14.358729437462937
. Please verify that the score and label color codes align with the overall dashboard strategy.
178-187
: Replaced Bug Issue: Search History Inconsistency
The issue titled "[Bug]: The Search History from Search Bar and Search Icon is not consistent" has been updated with a new resource path and author information. Ensure that this change correctly reflects the latest reported issue and that any downstream references to the old issue are updated accordingly.
188-202
: New GoodFirstIssue: Social Sharing Buttons Feature
A new issue entry "[FEATURE] " targeting social sharing functionality has been added under thetypescript
area with an "enhancement" label. This looks well formatted. Ensure that the issue description provides enough technical context for contributors.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores