ci: testing of automerge changes #3662
Conversation
Shurtu-gal
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces changes to the automerge workflow in the GitHub Actions configuration. The modifications reformat the conditional statement for improved clarity, update the commit author retrieval step to use Changes
Sequence Diagram(s)sequenceDiagram
participant PR as Pull Request Event
participant WF as Workflow
participant API as GitHub API
PR->>WF: Trigger automerge workflow
WF->>WF: Check conditions (not draft, initiator not bot)
WF->>API: Retrieve commit data using actions/github-script
API-->>WF: Return commit list
WF->>WF: Extract unique authors and create commit message
WF->>WF: Merge PR using the updated commit message
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3662 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/automerge-for-humans-merging.yml (2)
29-48: Positive Update: Robust Retrieval of PR Commit AuthorsThe updated "Get PR authors" step leverages
actions/github-script@v7with GitHub's REST API and pagination, which improves error handling and overall robustness. Ensure that the output provided from this step is correctly utilized by subsequent steps.
49-83: Nitpick: Remove Extra Semicolon in Debug StatementThe "Create commit message" step correctly aggregates unique commit authors and formats the commit message accordingly. However, on line 80 the debug statement contains an extra semicolon (
core.debug(coAuthors);;). Please remove the superfluous semicolon.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/automerge-for-humans-merging.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/automerge-for-humans-merging.yml
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 24-24: trailing spaces
(trailing-spaces)
[error] 25-25: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
.github/workflows/automerge-for-humans-merging.yml (1)
84-94: Approved: Correct Integration of Commit Message for AutomergeThe automerge step now properly incorporates the commit message (including co-authorship information) from the previous step. This change ensures that multi-author commits are documented per GitHub’s guidelines.
| # it runs only if PR actor is not a bot, at least not a bot that we know | ||
| if: | | ||
| github.event.pull_request.draft == false && | ||
| (github.event.pull_request.user.login != 'asyncapi-bot' || | ||
| github.event.pull_request.user.login != 'dependabot[bot]' || | ||
| github.event.pull_request.user.login != 'dependabot-preview[bot]') | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Critical: Incorrect Bot Filtering Logic and Trailing Spaces
- The current condition uses OR operators to check for bot usernames, which causes the condition to always evaluate to true—even when the PR actor is a known bot. To correctly exclude all specified bots, change the inner condition to use AND operators. For example, use:
github.event.pull_request.user.login != 'asyncapi-bot' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.user.login != 'dependabot-preview[bot]' - Additionally, static analysis indicates trailing spaces on lines 23-26. Please remove these trailing spaces to comply with YAML formatting standards.
[refactor_suggestion_essential]
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 23-23: trailing spaces
(trailing-spaces)
[error] 24-24: trailing spaces
(trailing-spaces)
[error] 25-25: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
|
/rtm |
Description
Summary by CodeRabbit
New Features
Bug Fixes