Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edavisualizer applicationView integration #243

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Om-Thorat
Copy link

Description

  • Integrated EdaVisualizer's aaplicationView into vs-code-asyncapi-preview plugin.
  • Made this prototype as a initial draft pr and as a part of my proposal for Mentorship Program 2024

Demo video

edavisualiserdemo.webm

Related issue(s)

Resolves #234

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarcloud bot commented Oct 21, 2024

@Om-Thorat Om-Thorat changed the title feat: Edavisualizer applicationView integration feat: edavisualizer applicationView integration Oct 21, 2024
@ibishal
Copy link

ibishal commented Oct 22, 2024

Looks exactly copy paste of #242, even the variable and function name are similar to this

@Om-Thorat
Copy link
Author

Looks exactly copy paste of #242, even the variable name similar to this

Variable names are according to the standard camelCase naming conventions so it's often that some will overlap. Very sorry you feel as such, most i can do is assure you it's independent work and i had to make this PR as a part of the proposal for the mentorship program since it was a step in the process.

@ivangsa
Copy link
Collaborator

ivangsa commented Oct 22, 2024

yes, PR #242 was almost ready to be merged already..

I can not tell if PR #243 is a copy or not, but the work was already in progress...

anyway I like the naming in commands #243
image

@ibishal can you update command names acordingly

If you have any question regarding mentorship program, please contact @AceTheCreator

@ibishal
Copy link

ibishal commented Oct 22, 2024

@ibishal can you update command names acordingly

Done 👍

@Om-Thorat
Copy link
Author

yes, PR #242 was almost ready to be merged already..

I can not tell if PR #243 is a copy or not, but the work was already in progress...

If you have any question regarding mentorship program, please contact @AceTheCreator

I made this PR according to the instructions in
https://github.com/orgs/asyncapi/discussions/1361#discussioncomment-10903413

Since it was a requirement before I share the proposal. I am unsure will my proposal be considered? I have texted Ace on Slack yet i am asking you since you are the mentioned mentor and you are the one I am supposed to share it with. Sorry if i am misunderstanding. Thanks.

@AceTheCreator
Copy link
Member

@ibishal @Om-Thorat Thank you for your interest in @ivangsa project idea.

I understand that there are concerns regarding similar PRs and potential code copying. I’ve spoken with the mentor, Ivan, and here are a few points I want to clarify:

The PR submission is one of the several criteria @ivangsa will use to evaluate candidates. Ivan will look at the overall proposal, quality of the work, and other requirements before making any decisions.

Similarities in PRs can happen, especially when working on a specific task, so this will not be the sole criteria for selection. Please be rest assured that Ivan will review all PRs carefully and fairly.
I encourage you to focus on your proposals and other requirements for the project. Ivan will use all this information to make a decision.

Please, let’s maintain a spirit of collaboration as we move forward.

Thank you all for your hard work and awesome contributions to the project 🚀

@Om-Thorat
Copy link
Author

Thank you for the clarification :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualize the application and how it interacts with the world
4 participants