fix(typescript-generator)!: handle 'date' and 'date-time' for 'string'…

[roman-supy-io]

… data type

Description

Date type was not properly handled and resulted into string generated type output
This fixes the issue

Related Issue

Checklist

• The code follows the project's coding standards and is properly linted (npm run lint).
• Tests have been added or updated to cover the changes.
• Documentation has been updated to reflect the changes.
• All tests pass successfully locally.(npm run test).

Additional Notes

[netlify]

✅ Deploy Preview for modelina canceled.

Name	Link
🔨 Latest commit	71b2f46
🔍 Latest deploy log	https://app.netlify.com/sites/modelina/deploys/67b86c85a4e37200082aae2f

[jonaslagoni]

@roman-supy-io remember to update all the test etc npm run test:update

[jonaslagoni]

Besides updating snapshots can you add two test to

modelina/test/generators/typescript/TypeScriptConstrainer.spec.ts

Line 82 in 039dab0

test('should render type', () => {

?

You can use the Java tests as guideline: https://github.com/asyncapi/modelina/blob/master/test/generators/java/JavaConstrainer.spec.ts#L329

[roman-supy-io]

@jonaslagoni tests updated

[jonaslagoni]

@roman-supy-io did you run npm run test:library -- -u or npm run test:update? Looks like there is still some snapshots that has not been updated 🙂

[sonarqubecloud]

Quality Gate failed

Failed conditions
41.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[roman-supy-io]

@jonaslagoni all fixed
question, because we use docker hub version of a generator, will the docker image be updated automatically?

[jonaslagoni]

@roman-supy-io which docker image specifically are you referring to?

[jonaslagoni]

Regardless, because this is a breaking change, I dont think any automatic updates will happen.

[roman-supy-io]

@jonaslagoni right now we're using https://hub.docker.com/r/asyncapi/cli on our CI to generate Typescript contracts

UPD: oh, ok, so when can we expect this to be released?
And why is it a breaking change? I'd rather call it feature/fix for the current major version.

[jonaslagoni]

@roman-supy-io you can read more about it here: https://github.com/asyncapi/modelina?tab=readme-ov-file#versioning-and-maintenance

Alternatively you can add a flag specifying an enum of types for date formats 🤔 i.e. string (default) and date so the output does not automatically break for the consumers of the models.