Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Java import for @Valid annotation #2179

Merged
merged 1 commit into from
Feb 9, 2025
+9 −3
Merged

fix: add missing Java import for @Valid annotation #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/generators/java/presets/ConstraintsPreset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const JAVA_CONSTRAINTS_PRESET: JavaPreset<JavaConstraintsPresetOptions> =
renderer.dependencyManager.addDependency(
`import ${importFrom}.validation.constraints.*;`
);
renderer.dependencyManager.addDependency(
`import ${importFrom}.validation.Valid;`
);
return content;
},
// eslint-disable-next-line sonarjs/cognitive-complexity
Expand Down
9 changes: 6 additions & 3 deletions test/generators/java/presets/ConstraintsPreset.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ describe('JAVA_CONSTRAINTS_PRESET', () => {
const generator = new JavaGenerator({ presets: [JAVA_CONSTRAINTS_PRESET] });
const expectedDependencies = [
'import java.util.Map;',
'import javax.validation.constraints.*;'
'import javax.validation.constraints.*;',
'import javax.validation.Valid;'
];

const models = await generator.generate(doc);
Expand All @@ -46,7 +47,8 @@ describe('JAVA_CONSTRAINTS_PRESET', () => {
});
const expectedDependencies = [
'import java.util.Map;',
'import javax.validation.constraints.*;'
'import javax.validation.constraints.*;',
'import javax.validation.Valid;'
];

const models = await generator.generate(doc);
Expand All @@ -68,7 +70,8 @@ describe('JAVA_CONSTRAINTS_PRESET', () => {
});
const expectedDependencies = [
'import java.util.Map;',
'import jakarta.validation.constraints.*;'
'import jakarta.validation.constraints.*;',
'import jakarta.validation.Valid;'
];

const models = await generator.generate(doc);
Expand Down