feat!: add union types support in go #1882
Conversation
✅ Deploy Preview for modelina canceled.
|
|
Also remember to add an entry into the migration guide for v4 as this is a breaking change for Go ✌️ |
Souvikns
requested review from
magicmatatjahu,
kennethaasan and
asyncapi-bot-eve
as code owners
|
@kennethaasan since you also seem to do some stuff in go atm, want to have a look? |
jonaslagoni
changed the title
|
|
||
| export interface GoOptions extends CommonGeneratorOptions<GoPreset> { | ||
| typeMapping: TypeMapping<GoOptions, GoDependencyManager>; | ||
| constraints: Constraints<GoOptions>; | ||
| unionAnyModelName: string; |
There was a problem hiding this comment.
Please add JS doc to each of these options so people got some idea when trying to use it instead of having to look it up ✌️
There was a problem hiding this comment.
Will the developer know what unionAnyModelName means by reading the description you just provided?
| const jsonSchemaDraft7 = { | ||
| $schema: 'http://json-schema.org/draft-07/schema#', | ||
| type: 'object', | ||
| additionalProperties: { |
There was a problem hiding this comment.
Do you mind changing the example so it outputs multiple Union types and then use the options for naming so we reflect those options you added?
There was a problem hiding this comment.
@Souvikns you never adapted the options to include all the unionAnyModelName and others. Right now users have no idea the options are there.
|
|
/rtm |
|
🎉 This PR is included in version 4.0.0-next.26 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds support for union types in go.
Related Issue
closes #1842
Checklist
npm run lint).npm run test).Additional Notes