Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Go union type support #1881

Closed
wants to merge 74 commits into from
Closed

feat: Go union type support #1881

wants to merge 74 commits into from

Conversation

Souvikns
Copy link
Member

Description

This PR aims to add support for union types in Go.

Related Issue

closes #1842

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

jonaslagoni and others added 30 commits November 8, 2023 13:12
@jonaslagoni
feat!: convert to use multi parser (asyncapi#1587)
94a3635
@jonaslagoni
Merge branch 'master' into next
9df2ef4
@kennethaasan
feat!: adds support for duration in java (asyncapi#1604)
e76e394
@asyncapi-bot
chore(release): v3.0.0-next.1 (asyncapi#1605)
52fd126
@jonaslagoni
feat: enable AsyncAPI v3 (asyncapi#1600)
125278e
@asyncapi-bot
chore(release): v3.0.0-next.2 (asyncapi#1606)
ef56f3e
@jano-petras
fix!: add csharp support for DateTime, TimeSpan, Guid (asyncapi#1612)
3aa1026
@asyncapi-bot
chore(release): v3.0.0-next.3 (asyncapi#1615)
280904c
@kennethaasan
feat!: adds extend in common, meta, and constrained models (asyncapi#…
0e9f0e7 
…1613)
@asyncapi-bot
chore(release): v3.0.0-next.4 (asyncapi#1617)
86bd90a
@kennethaasan
feat!: adds inheritance with interfaces for java (asyncapi#1593)
379c35d
@asyncapi-bot
chore(release): v3.0.0-next.5 (asyncapi#1625)
91dfeca
@jonaslagoni
chore: remove duplicate version entry for AsyncAPI processor (asyncap…
41c2daf 
…i#1609)
@kennethaasan
feat!: render python union in pydantic in the pre 3.10 way (asyncapi#…
7ac3259 
…1626)
@asyncapi-bot
chore(release): v3.0.0-next.6 (asyncapi#1627)
3558b26
@nilkanth987
feat: add file path as input (asyncapi#1601)
268bfd4
@asyncapi-bot
chore(release): v3.0.0-next.7 (asyncapi#1630)
851f121
@jonaslagoni
chore: merge branch master into next
8c836f6
@jonaslagoni
chore: updated next with master (asyncapi#1675)
3cdb662
@jonaslagoni
feat!: add options as parameter to constraints (asyncapi#1667)
396dd69
@asyncapi-bot
chore(release): v3.0.0-next.8 (asyncapi#1693)
d3855c8
@jonaslagoni
fix: (un)marshalling tuple and dictionary unwrapping for Typescript (a…
d8f1600 
…syncapi#1717)
@asyncapi-bot
chore(release): v3.0.0-next.9 (asyncapi#1734)
651eaeb 
Co-authored-by: asyncapi-bot <[email protected]>
@jonaslagoni
fix: jsonbinpack preset and runtime tests (asyncapi#1718)
7cdee96
@asyncapi-bot
chore(release): v3.0.0-next.10 (asyncapi#1735)
793b385
@jonaslagoni
chore: merge master into next
b68626f
@jonaslagoni
chore: fix linting
2358a96
@jonaslagoni
chore: remove unused directory
1d30dda
@jonaslagoni
feat: update next with master (asyncapi#1737)
a7c2311
@jonaslagoni
feat!: add useJavascriptReservedKeywords option for TS (asyncapi#1727)
384a16c
asyncapi-bot and others added 21 commits February 19, 2024 10:38
@asyncapi-bot
chore(release): v4.0.0-next.4 (asyncapi#1822)
283c873
@jonaslagoni
chore: merge branch 'master-github-upstream' into 'next_update_with_m…
1e14060 
…aster'
@jonaslagoni
chore: update next with master (asyncapi#1837)
4811e7a
@asyncapi-bot
chore(release): v4.0.0-next.5 (asyncapi#1838)
aa0f5f1 
Co-authored-by: asyncapi-bot <[email protected]>
@JFCote
fix!: mapping for C# object date (asyncapi#1834)
35f0dad
@asyncapi-bot
chore(release): v4.0.0-next.6 (asyncapi#1839)
0d2f4df
@JFCote
fix: handle null with new string renderers (asyncapi#1841)
513c489
@asyncapi-bot
chore(release): v4.0.0-next.7 (asyncapi#1844)
5f6ea52
@kennethaasan
feat!: python pydantic follows v2 (asyncapi#1851)
2e2c0c2
@asyncapi-bot
chore(release): v4.0.0-next.8 (asyncapi#1852)
8ec6814
@jonaslagoni
update implementation and test
83a8468
@jonaslagoni
chore: revert 83a8468
663191f 
This reverts commit 83a8468.
@jonaslagoni
fix: add serialization alias for Pydantic (asyncapi#1859)
9495a40
@asyncapi-bot
chore(release): v4.0.0-next.9 (asyncapi#1863)
e9272bf 
Co-authored-by: asyncapi-bot <[email protected]>
@jonaslagoni
fix: exclude unwrappable dictionaries for pydantic preset (asyncapi#1860
e0e1741 
)
@asyncapi-bot
chore(release): v4.0.0-next.10 (asyncapi#1864)
741681c 
Co-authored-by: asyncapi-bot <[email protected]>
@jonaslagoni
fix: only self hook was called in Go enums (asyncapi#1855)
92908b9
@asyncapi-bot
chore(release): v4.0.0-next.11 (asyncapi#1866)
dca4c98 
Co-authored-by: asyncapi-bot <[email protected]>
@Souvikns
feat: add json serialisation support for golang (asyncapi#1848)
0b0f56e
@asyncapi-bot
chore(release): v4.0.0-next.12 (asyncapi#1869)
631d170 
Co-authored-by: asyncapi-bot <[email protected]>
@Souvikns
feat: add union types support in go
3e200e1
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 3e200e1
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65eedbcaed623e00088c4a4e

@asyncapi-bot
Copy link
Contributor

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 The subject "Go union type support" found in the pull request title "feat: Go union type support" should start with a lowercase character.

@Souvikns Souvikns closed this Mar 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samridhi-98 Samridhi-98 Awaiting requested review from Samridhi-98 Samridhi-98 is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] go generator is unable to handle unions types correctly.
8 participants
@Souvikns @asyncapi-bot @jonaslagoni @kennethaasan @jano-petras @nilkanth987 @marakalwa @JFCote