Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Emojis Not Rendering Properly #1702

Merged
merged 2 commits into from
Dec 27, 2023
Merged

docs: update Emojis Not Rendering Properly #1702

merged 2 commits into from
Dec 27, 2023

Conversation

devansh-m12
Copy link
Contributor

@devansh-m12 devansh-m12 commented Dec 26, 2023

Description

This pull request addresses the issue [#1701]: "Emojis Not Rendering Properly in Hosted GitHub Documentation." The problem was related to inconsistencies in emoji rendering when the documentation is hosted on a website.

Related Issue

fixes #1701

Changes Made

  • Updated the shortcut emojis to animated ones to resolve the rendering issue.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 985c75f
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/658bbc7f2008210008b09f54

@coveralls
Copy link

coveralls commented Dec 26, 2023

Pull Request Test Coverage Report for Build 7335553639

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.296%

Totals Coverage Status
Change from base Build 7335551203: 0.0%
Covered Lines: 5864
Relevant Lines: 6192

💛 - Coveralls

@devansh-m12 devansh-m12 changed the title Update Emojis Not Rendering Properly docs: Update Emojis Not Rendering Properly Dec 27, 2023
@devansh-m12 devansh-m12 changed the title docs: Update Emojis Not Rendering Properly docs: update Emojis Not Rendering Properly Dec 27, 2023
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devansh-m12 👍

@jonaslagoni jonaslagoni merged commit 0408e99 into asyncapi:master Dec 27, 2023
13 checks passed
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs Bug 🐞 report]: Emojis Not Rendering Properly in Hosted Documentation
4 participants