-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : update async-cli package to use ES modules #1716
base: master
Are you sure you want to change the base?
Conversation
Fixes asyncapi#1698 Update `async-cli` package to use ES modules instead of CommonJS. * **Update `tsconfig.json` files:** - Change `module` to `ESNext` in `tsconfig.json`, `assets/create-glee-app/templates/default/tsconfig.json`, and `assets/create-glee-app/templates/tutorial/tsconfig.json`. - Update `moduleResolution` to `node` in the same files. * **Update `package.json`:** - Add `"type": "module"`. * **Update import/export syntax:** - Modify import statements in `src/commands/bundle.ts`, `src/commands/convert.ts`, `src/commands/generate/fromTemplate.ts`, `scripts/fetch-asyncapi-example.js`, `scripts/releasePackagesRename.js`, and `src/index.ts` to use ES module syntax.
|
We require all PRs to follow Conventional Commits specification.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Fixes #1698
Update
async-cli
package to use ES modules instead of CommonJS.Update
tsconfig.json
files:module
toESNext
intsconfig.json
,assets/create-glee-app/templates/default/tsconfig.json
, andassets/create-glee-app/templates/tutorial/tsconfig.json
.moduleResolution
tonode
in the same files.Update
package.json
:"type": "module"
.Update import/export syntax:
src/commands/bundle.ts
,src/commands/convert.ts
,src/commands/generate/fromTemplate.ts
,scripts/fetch-asyncapi-example.js
,scripts/releasePackagesRename.js
, andsrc/index.ts
to use ES module syntax.