Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print in cli asyncapi generate models without -o flag #1664

Merged
merged 9 commits into from
Feb 18, 2025

Conversation

Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Feb 14, 2025

Description

asyncapi generate models LANGUAGE FILE can print the output in CLI itself if -o flag is missing.

image

Related issue(s)
Fixes: #1654

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: 392b6c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 14, 2025

@AayushSaini101 please review the PR and provide the feedback thanks : )

@AayushSaini101 AayushSaini101 changed the title fix: print in CLI asyncapi generate models without -o flag fix: print in cli asyncapi generate models without -o flag Feb 15, 2025
@AayushSaini101
Copy link
Collaborator

@AayushSaini101 please review the PR and provide the feedback thanks : )

can you please test case if it is possible thanks @Adi-204

@AayushSaini101
Copy link
Collaborator

/u

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 15, 2025

image

@AayushSaini101 Sir added a testcase for without specified output directory. Please provide feedback thanks : )

@AayushSaini101
Copy link
Collaborator

/u

@AayushSaini101
Copy link
Collaborator

/u

@AayushSaini101
Copy link
Collaborator

LGTM

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 2deeb36 into asyncapi:master Feb 18, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] asyncapi generate models LANGUAGE FILE command not giving desired output without -o flag
4 participants