Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new command for asyncapi start preview #1637

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions src/commands/bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,11 @@ export default class Bundle extends Command {

this.metricsMetadata.files = AsyncAPIFiles.length;

const document = await bundle(AsyncAPIFiles,
{
base: flags.base,
baseDir: flags.baseDir,
xOrigin: flags.xOrigin,
}
);
const document = await this.bundleFiles(AsyncAPIFiles, {
base: flags.base,
baseDir: flags.baseDir,
xOrigin: flags.xOrigin,
});

await this.collectMetricsData(document);

Expand Down Expand Up @@ -65,6 +63,13 @@ export default class Bundle extends Command {
}
}

private async bundleFiles(
files: string[],
options: { base?: string; baseDir?: string; xOrigin?: boolean }
): Promise<Document> {
return await bundle(files, options);
}

private async collectMetricsData(document: Document) {
try {
// We collect the metadata from the final output so it contains all the files
Expand All @@ -75,4 +80,15 @@ export default class Bundle extends Command {
}
}
}

/**
* Expose a utility method to bundle and return the bundled document in memory.
* Useful for commands like `start preview`.
*/
public static async bundleInMemory(
files: string[],
options: { base?: string; baseDir?: string; xOrigin?: boolean }
): Promise<Document> {
return await bundle(files, options);
}
}
64 changes: 64 additions & 0 deletions src/commands/start/preview.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
// test/commands/start/preview.test.ts
import { expect, test } from '@oclif/test';
import { promises as fs } from 'fs';
import path from 'path';
import { bundleInMemory } from '../../../src/commands/bundle';

Check failure on line 5 in src/commands/start/preview.test.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Module '"../../../src/commands/bundle"' has no exported member 'bundleInMemory'. Did you mean to use 'import bundleInMemory from "../../../src/commands/bundle"' instead?
import { startPreview } from '../../../src/commands/start/preview'; //

Check failure on line 6 in src/commands/start/preview.test.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Module '"../../../src/commands/start/preview"' has no exported member 'startPreview'. Did you mean to use 'import startPreview from "../../../src/commands/start/preview"' instead?

const asyncAPISpecPath = './test/fixtures/spec/asyncapi.yaml';
const asyncAPIWithRefsPath = './test/fixtures/spec/asyncapi-with-refs.yaml';

async function setupTestSpecFiles() {
await fs.mkdir(path.dirname(asyncAPISpecPath), { recursive: true });
await fs.writeFile(
asyncAPISpecPath,
'asyncapi: "2.0.0"\ninfo:\n title: Test API\n version: "1.0.0"\n'
);
await fs.writeFile(
asyncAPIWithRefsPath,
'asyncapi: "2.0.0"\ninfo:\n title: Test API with Refs\n version: "1.0.0"\ncomponents:\n schemas:\n example: \n $ref: ./example-schema.yaml\n'
);
}

describe('start preview', () => {
before(async () => {
await setupTestSpecFiles();
});

after(async () => {
await fs.rm('./test/fixtures', { recursive: true, force: true });

Check failure on line 29 in src/commands/start/preview.test.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Property 'rm' does not exist on type 'typeof promises'.
});

test
.stdout()
.stderr()
.do(async () => {
const bundledDoc = await bundleInMemory([asyncAPISpecPath], {});
await startPreview(bundledDoc.string(), { readOnly: true });
})
.it('should start preview with a bundled AsyncAPI document', (ctx) => {
expect(ctx.stdout).to.contain('Preview started');
});

test
.stdout()
.stderr()
.do(async () => {
const bundledDoc = await bundleInMemory([asyncAPIWithRefsPath], {});
await startPreview(bundledDoc.string(), { readOnly: true });
})
.it('should handle references correctly during preview', (ctx) => {
expect(ctx.stdout).to.contain('Preview started');
});

test
.stderr()
.do(async () => {
try {
await startPreview('', { readOnly: true });
} catch (error) {
expect(error.message).to.contain('Invalid AsyncAPI document');

Check failure on line 60 in src/commands/start/preview.test.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

'error' is of type 'unknown'.
}
})
.it('should throw an error for invalid or empty AsyncAPI documents');
});
44 changes: 44 additions & 0 deletions src/commands/start/preview.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { Command } from '@oclif/core';
import chokidar from 'chokidar';
import { bundle } from '../bundler';

Check failure on line 3 in src/commands/start/preview.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Cannot find module '../bundler' or its corresponding type declarations.
import { startStudio } from '../studio';
import path from 'path';
import fs from 'fs';

export default class StartPreview extends Command {

Check failure on line 8 in src/commands/start/preview.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Class static side 'typeof StartPreview' incorrectly extends base class static side 'typeof Command'.
static description = 'Start a live preview of your AsyncAPI document with references resolved.';

static args = [
{ name: 'file', required: true, description: 'Path to the AsyncAPI file' },
];

async run() {
const { args } = await this.parse(StartPreview);

Check failure on line 16 in src/commands/start/preview.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Argument of type 'typeof StartPreview' is not assignable to parameter of type 'Input<{ [flag: string]: any; }, { [flag: string]: any; }, unknown[]>'.

const filePath = path.resolve(args.file);

Check failure on line 18 in src/commands/start/preview.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

Property 'file' does not exist on type 'unknown[]'.
if (!fs.existsSync(filePath)) {
this.error(`File not found: ${filePath}`);
}

const bundleAndPreview = async () => {
try {
this.log('Bundling AsyncAPI file...');
const bundledDocument = await bundle(filePath);
this.log('Starting Studio in preview mode...');
await startStudio(bundledDocument, { readOnly: true });
} catch (error) {
this.error(`Error bundling AsyncAPI file: ${error.message}`);

Check failure on line 30 in src/commands/start/preview.ts

View workflow job for this annotation

GitHub Actions / Test NodeJS PR - ubuntu-latest

'error' is of type 'unknown'.
}
};

await bundleAndPreview();

const watcher = chokidar.watch(filePath, { ignoreInitial: true });
watcher.on('change', async () => {
this.log('File changed. Reloading preview...');
await bundleAndPreview();
});

this.log('Watching for file changes. Press Ctrl+C to stop.');
}
}
9 changes: 9 additions & 0 deletions src/commands/studio.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import open from 'open';

export async function startStudio(bundledDocument: string, options: { readOnly: boolean }) {
const studioUrl = `https://studio.asyncapi.com/?readOnly=${options.readOnly}&document=${encodeURIComponent(
bundledDocument
)}`;

await open(studioUrl);
}
Loading