Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.6.3 #845

Merged
merged 2 commits into from
Aug 13, 2020
Merged

chore: release v1.6.3 #845

merged 2 commits into from
Aug 13, 2020

Conversation

dignifiedquire
Copy link
Member

No description provided.

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, looks good!

It seems we're missing a cargo fmt pass; but we can do that in a separate PR. Excited for this!

@dignifiedquire
Copy link
Member Author

@yoshuawuyts the errors are real, it seems that the docs macro broke :O

@dignifiedquire
Copy link
Member Author

Tested and older nightlies (2020-05-01) compiles the docs fine. So there is either a regression or a sudden change in the compiler that breaks things

@dignifiedquire
Copy link
Member Author

I suspect rust-lang/rust#73566 to be the issue

@yoshuawuyts
Copy link
Contributor

@dignifiedquire oooph ://

I've added a comment on the issue you linked so people are notified. But we should probably open a dedicated issue for it on the compiler. It's annoying we now cannot release :(

@Keruspe
Copy link
Member

Keruspe commented Aug 13, 2020

Blocking issue has been addressed in latest nightly right?

@killzoner
Copy link
Contributor

Apparently yes (rust-lang/rust#75100 (comment)), but somehow nobody had time to rerun CI. Probably soon

@dignifiedquire
Copy link
Member Author

I tried rerunning, but I don't know how to get github actions to pick up the newer nightly :/

@killzoner
Copy link
Contributor

@dignifiedquire it did the trick 🎉

@dignifiedquire dignifiedquire merged commit 9a16081 into master Aug 13, 2020
@dignifiedquire dignifiedquire deleted the 1-6-3 branch August 13, 2020 13:02
@dignifiedquire
Copy link
Member Author

Released, finally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants