Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · 3254750 · 3254750
1 parent a48b213
commit 3254750
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Changed
 
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
 - AWS enhancement: Documentation updates.
 
 ## 2.4.0

diff --git a/src/Input/BatchGetBuildsInput.php b/src/Input/BatchGetBuildsInput.php
@@ -58,6 +58,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'CodeBuild_20161006.BatchGetBuilds',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/StartBuildInput.php b/src/Input/StartBuildInput.php
@@ -644,6 +644,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'CodeBuild_20161006.StartBuild',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/src/Input/StopBuildInput.php b/src/Input/StopBuildInput.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'CodeBuild_20161006.StopBuild',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

diff --git a/tests/Unit/Input/BatchGetBuildsInputTest.php b/tests/Unit/Input/BatchGetBuildsInputTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
         POST / HTTP/1.0
         Content-Type: application/x-amz-json-1.1
         x-amz-target: CodeBuild_20161006.BatchGetBuilds
+        Accept: application/json
 
         {
             "ids": ["build1"]

diff --git a/tests/Unit/Input/StartBuildInputTest.php b/tests/Unit/Input/StartBuildInputTest.php
@@ -149,6 +149,7 @@ public function testRequest(): void
         POST / HTTP/1.0
         Content-Type: application/x-amz-json-1.1
         x-amz-target: CodeBuild_20161006.StartBuild
+        Accept: application/json
 
         {
             "artifactsOverride": {

diff --git a/tests/Unit/Input/StopBuildInputTest.php b/tests/Unit/Input/StopBuildInputTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
         POST / HTTP/1.0
         Content-Type: application/x-amz-json-1.1
         x-amz-target: CodeBuild_20161006.StopBuild
+        Accept: application/json
 
         {
             "id": "build-1"