-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datastore Integration #814
Conversation
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
…e-datapack-integration
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 81.31% 80.58% -0.74%
==========================================
Files 250 250
Lines 19067 19153 +86
==========================================
- Hits 15505 15434 -71
- Misses 3562 3719 +157
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set up the versions (https://github.com/asyml/forte/blob/master/forte/version.py#L23) to make sure Forte will detect that old serialization won't be supported.
This PR fixes #573 .
Description of changes
_pending_entries
mechanismBasePack.regret_creation
and its corresponding test cases.DataPack
,_pending_entries
will storeentry.tid
instead ofentry
itself.add_entry
,record_entry
,_add_entry
,__add_entry_with_check
, etc.DataStore
is integrated withMultiPack
, we should only maintain a mapping from entry's tid to the corresponding component, i.e., Dict[int, Optional[str]].SortedList
containers of entries inDataPack
DataPack._data_store
DataStore
EntryConverter
is created to facilitate the conversion between entry data fromDataStore
and the class object.DataPack
stave_reader_test
andentry_data_structures_test
_onto_file_path
and_dynamically_add_type
inDataStore.__getstate__
to avoid failure in test cases.FList
/FDict
Pointer
to resolve entriesDataStore
Annotation
,Group
,Link
,Generics
,AudioAnnotation
DataStore
DataStore
all_entries()
should generate entries in order, so now we should useco_iterator_annotation_like()
for annotation-like entries.get()
should not requiredtype_name
to exist in__elements
wheninclude_sub_type
is enabled if it's notGenerics
.Possible influences of this PR.
The current integration is probably going to be unstable, hence it's only for 0.3 pre-release (0.3.0dev1). We will need to fix a lot of follow-up issues in 0.3 stable version and 0.3 interface clearance.
Test Conducted
The integration should successfully pass all the current CI tests. Will need more dedicated test cases in future (#808).