Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data initalisation and parameter names #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nocturnalastro
Copy link
Collaborator

Fixes the error caused by not passing the attributes into the __init__ as done by sherpa

Signed-off-by: Michele Costa <[email protected]>
@hamogu
Copy link
Member

hamogu commented Mar 2, 2020

Thanks for looking after your old package again! Are you actively using it?
I checked the Travis failures, I think the two failures are real, and are essentially "code rot" where the environment has changed around us since the last saba release.

Astropy has refactored the testing packages, such that we now may have to install different / new dependencies for the testing. I've migrated one of my other packages recently, I'll see if I can propose a fix for that in a separate PR.

The second thing might be due to changes in the modelling. I'll open a separate issue for that, but I don't know on top of my head how to address that.
@nocturnalastro: What do you think?

@nocturnalastro
Copy link
Collaborator Author

@hamogu
I've not been using it unfortunately, probably why I've let the code get so rotten. I have a fix for the attribute error, It was due to some changes in astropy where the parameters are references instead of copies (by the looks of it). But the fix is very simple just use the loop variable which has the correct name, I fixed it last night but forgot to push it because I found something else to fix in astropy.

@nocturnalastro nocturnalastro changed the title Fix data initalisation Fix data initalisation and parameter names Mar 2, 2020
@nocturnalastro
Copy link
Collaborator Author

Ah yes this is how I noticed the problem with astropy so until get astropy/astropy#10002 sorted it we that won't pass unless I rewrite the examples in the docs.

Base automatically changed from master to main March 11, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants