Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 504] add "detail=min" parameter #634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chmmao
Copy link
Contributor

@chmmao chmmao commented Dec 23, 2024

This is an attempt to address the Issue #504 by adding an additional parameter "detail=min" to the tables function.
When running the following code:

from pyvo import registry
registry.search(registry.Spatial((10, 10)), registry.Freetext("egal")) 

The runtime improves from 2s down to 1.2s (on my machine), while the output size is unchanged.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.31%. Comparing base (a9ac860) to head (86e52de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files          72       72           
  Lines        7429     7429           
=======================================
  Hits         6115     6115           
  Misses       1314     1314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant