Get list of unique products #3096
Open
+83
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrojimig
reviewed
Sep 20, 2024
| products = self.get_product_list(observations) | ||
| unique_products = self._remove_duplicate_products(products) | ||
| if len(unique_products) < len(products): | ||
| log.info("To return all products, use `Observations.get_product_list`") |
There was a problem hiding this comment.
This log message could be slightly more informative if you include the numbers, for example "{len(products) - len(unique_products)} duplicate products removed; To return all products, use Observations.get_product_list"
There was a problem hiding this comment.
Ah never mind, the other log message captures that info! You're way ahead of me :)
|
This looks good! Thanks @snbianco ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation, a test, and documentation for a new function (
Observations.get_unique_product_list). Given observations, the function returns a list of associated data products, each with a unique data URI. This is essentially a wrapper toObservations.get_product_listthat removes duplicate rows before returning.Because
get_product_listis a query method, it should be async and return a response that is then parsed into a Table. Because we need the actual result Table to remove the duplicates, I wasn't able to add this functionality as a parameter to the original function. It's possible that theMast.Caom.Productsservice could filter out duplicates at some point, but I think this is the best solution for now.