Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: adding Python 3.13 to CI #3088

Merged
merged 2 commits into from
Aug 27, 2024
Merged

MAINT: adding Python 3.13 to CI #3088

merged 2 commits into from
Aug 27, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 27, 2024

If we're compatible out of the box then no changelog entry will be needed...

(locally I see one doctesting whitespace issue, it may actually be an upstream doctestplus issue)

@pllim
Copy link
Member

pllim commented Aug 27, 2024

I think the whitespace problem is from Python 3.13 itself. According to https://docs.python.org/3.13/whatsnew/3.13.html, "The compiler now strips common leading whitespace from every line in a docstring."

Is there a reason why you must keep the leading whitespace? If not, would be much simpler to adjust the test for Python 3.13 and later. FYI.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 27, 2024

A good to know, thanks, I'll change the test then.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 27, 2024

This now has a pragmatic workaround for python/cpython#81283

tox.ini Show resolved Hide resolved
@bsipocz bsipocz merged commit 01c4d29 into astropy:main Aug 27, 2024
9 checks passed
@bsipocz bsipocz deleted the MAINT_py313 branch August 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants