Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for TESS/TICA FFIs when getting products for observations #3083

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

snbianco
Copy link
Contributor

@snbianco snbianco commented Aug 9, 2024

To try and decrease load on the MAST server, we would like to prevent Astroquery users from getting products for TESS and TICA FFIs. When a user tries to do this, they should be presented with a warning message that presents alternate methods for downloading.

Right now, this filter only works if the user passes in a Row or Table to get_product_list, since we need access to the target_name field. We're aware that this is a limitation and will explore other options if we continue to receive these type of expensive requests from Astroquery.

@pep8speaks
Copy link

pep8speaks commented Aug 9, 2024

Hello @snbianco! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-08-09 19:05:55 UTC

@snbianco snbianco marked this pull request as ready for review August 9, 2024 19:09
@bsipocz bsipocz added this to the v0.4.8 milestone Aug 10, 2024
@bsipocz bsipocz merged commit 1c1588e into astropy:main Aug 10, 2024
8 checks passed
@bsipocz
Copy link
Member

bsipocz commented Aug 10, 2024

thanks!

@snbianco snbianco deleted the ASB-28093-tess-tica-check branch August 12, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants