Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: refactored out runtime dependency on setuptools #3071

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

neutrinoceros
Copy link
Contributor

Context:

I followed the upstream migration guide here.

@pep8speaks
Copy link

pep8speaks commented Jul 19, 2024

Hello @neutrinoceros! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-19 16:06:35 UTC

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (26050ed) to head (61adcf2).
Report is 23 commits behind head on main.

Files Patch % Lines
astroquery/alma/core.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3071      +/-   ##
==========================================
- Coverage   67.55%   67.44%   -0.11%     
==========================================
  Files         233      233              
  Lines       18327    18370      +43     
==========================================
+ Hits        12380    12390      +10     
- Misses       5947     5980      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neutrinoceros neutrinoceros force-pushed the dep/ditch_setuptools branch 2 times, most recently from a8b0556 to 99f1d96 Compare July 19, 2024 15:50
@neutrinoceros neutrinoceros marked this pull request as ready for review July 19, 2024 15:54
@neutrinoceros neutrinoceros marked this pull request as draft July 19, 2024 16:03
@neutrinoceros neutrinoceros marked this pull request as ready for review July 19, 2024 16:09
@ceb8 ceb8 added this to the v0.4.8 milestone Aug 15, 2024
@ceb8 ceb8 merged commit 471053f into astropy:main Aug 23, 2024
8 checks passed
@ceb8
Copy link
Member

ceb8 commented Aug 23, 2024

Thanks @neutrinoceros !

@neutrinoceros neutrinoceros deleted the dep/ditch_setuptools branch August 24, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants