BUG: better handling the optional dependency required for functionality #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andamian
approved these changes
Jun 14, 2024
| @@ -218,6 +218,7 @@ def get_enhanced_table(result): | |||
| print( | |||
| "Could not import astropy-regions, which is a requirement for get_enhanced_table function in alma." | |||
| "Please refer to http://astropy-regions.readthedocs.io/en/latest/installation.html for how to install it.") | |||
| raise | |||
There was a problem hiding this comment.
Hmm. I thought I did this. Wondering if that got lost in the rebase exercise which gave me a bit of a headache...
|
Sorry about this. Pretty sure I had it right but it probably got lost when I did the rebasing. |
|
No worries, it should have been picked up by the review anyway, but I only noticed it as I saw the test failing today in an env where regions was not present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the remote tests were failing when
regionswasn't installed, which highlighted the case that we didn't handle the missing dependency well in the function too (e.g. the module should not fail if it's missing, but it should fail rather than just print a message when someone tries to use the method).