Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of spectral resolution #3035

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

andamian
Copy link

@andamian andamian commented Jun 13, 2024

Fix for #1816

Both (m)
Alma.query_async(payload={'em_resolution': 6.929551916151968e-05})
and (KHz)
Alma.query_async(payload={'spectral_resolution':2000000})
work

Column spectral_resolution is also available from direct TAP queries.

@pep8speaks
Copy link

pep8speaks commented Jun 14, 2024

Hello @andamian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-14 18:16:28 UTC

@bsipocz bsipocz added this to the v0.4.8 milestone Jun 14, 2024
@bsipocz bsipocz merged commit 19ba3e5 into astropy:main Jun 14, 2024
8 checks passed
@bsipocz
Copy link
Member

bsipocz commented Jun 14, 2024

Thanks!

@andamian
Copy link
Author

No. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants