Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulate verbosity on download_products() function #3031

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

snbianco
Copy link
Contributor

@snbianco snbianco commented Jun 11, 2024

Fixes #3029

Adds a verbose parameter to relevant functions so that if verbose = False, no progress is output.

@pep8speaks
Copy link

pep8speaks commented Jun 11, 2024

Hello @snbianco! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-14 20:19:47 UTC

@snbianco snbianco force-pushed the download-products-verbosity branch 3 times, most recently from bd4057a to 4322fb7 Compare June 12, 2024 16:36
@snbianco snbianco marked this pull request as ready for review June 12, 2024 16:52
@snbianco snbianco force-pushed the download-products-verbosity branch from 9ae3c4b to 8e90326 Compare June 12, 2024 17:09
@bsipocz bsipocz added the mast label Jun 12, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Jun 12, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, however, I'll go ahead and do a rebase to remove the unrelated changes from one of the commits and well as the merge commit and more recent conflict.

If tests agree afterwords, I'll go ahead and merge.

@bsipocz bsipocz force-pushed the download-products-verbosity branch from 9194c4f to a5189c6 Compare June 14, 2024 20:19
@bsipocz bsipocz merged commit 2f2a643 into astropy:main Jun 14, 2024
8 checks passed
@bsipocz
Copy link
Member

bsipocz commented Jun 14, 2024

Thanks @snbianco!

@snbianco snbianco deleted the download-products-verbosity branch July 3, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modulate verbosity of astroquery.mast.Observations.download_products()
3 participants