Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaia: delete any reference to data_structure "Combined" in the function load_data and in the documentation [ci skip] #3012

Conversation

cosmoJFH
Copy link
Contributor

In a near future, the gaia datalink service is going to generate ancillary products for data_structure as "Individual" or "Raw", so the option "Combined" will not be available anymore.

We would like to delete any reference to this data_structure in the method load_data as well as in the general documentation.

cc @esdc-esac-esa-int

Jira ticket: GAIAMNGT-1704

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'm on the fence of this needs a changelog, after all we don't do any validation just passing it directly to the server.

So for now I leave it as is, and revisit at release time.

@bsipocz bsipocz added the gaia label May 27, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone May 27, 2024
@bsipocz bsipocz merged commit 25e6521 into astropy:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants